Skip to content

Removing cert keys from cm#55

Open
salaboy wants to merge 1 commit into
dapr:mainfrom
salaboy:remove-cm
Open

Removing cert keys from cm#55
salaboy wants to merge 1 commit into
dapr:mainfrom
salaboy:remove-cm

Conversation

@salaboy

@salaboy salaboy commented Sep 20, 2024

Copy link
Copy Markdown
Collaborator
  • removing unneded env variables related to certificates from init container.

Signed-off-by: salaboy <Salaboy@gmail.com>
@salaboy

salaboy commented Sep 23, 2024

Copy link
Copy Markdown
Collaborator Author

@JoshVanL @yaron2 please review and let me know if I can release a new version of the dapr-shared init container and helm chart

@JoshVanL

Copy link
Copy Markdown

@salaboy we need to update the RBAC permissions as well- we currently can get secrets in all namespaces, as well as read/write ConfigMaps in all namespaces.

@salaboy

salaboy commented Sep 23, 2024

Copy link
Copy Markdown
Collaborator Author

@JoshVanL that is a good point.. I will check that too

@salaboy

salaboy commented Sep 24, 2024

Copy link
Copy Markdown
Collaborator Author

@JoshVanL is there any recommended scope that we should use? Should I copy the RBAC from another component?

@JoshVanL

Copy link
Copy Markdown

@salaboy dapr shared shouldn't need any ClusterRoles at all.

@salaboy

salaboy commented Sep 24, 2024

Copy link
Copy Markdown
Collaborator Author

@salaboy

salaboy commented Sep 25, 2024

Copy link
Copy Markdown
Collaborator Author

TODO:

  • Create a Job on the dapr-system namespace to do the init container bit for the trust anchors
  • Create a new Service Account that lives in the dapr-system namespace to enable the copy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants